Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated boolean serialization #4345

Merged
merged 3 commits into from
Jul 11, 2020
Merged

updated boolean serialization #4345

merged 3 commits into from
Jul 11, 2020

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Jul 10, 2020 •
edited by ghost

Related Issue

Fixed #4322, Fixed #4344

Description

  1. When bool values such as true or false is returned, the value was serialized to True or False which is incorrect.
  2. in [.NET WPF][Rendering] [Unable to render only the template] #4344, when there is only one template string, and data context is not present, string wrapping didn't occur.

How Verified

How you verified the fix, including one or all of the following:

  1. New unit test is added.
  2. Existing unit tests are tested
  3. Tested all scenarios cards, and verified that all performed as expected.
Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft merged commit 417e6c7 into main Jul 11, 2020
@jwoo-msft jwoo-msft deleted the jwoo/net-template-update branch July 11, 2020 05:20
@jwoo-msft jwoo-msft mentioned this pull request Jul 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcam206 paulcam206 paulcam206 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jwoo-msft @paulcam206