[Renderer] Don't rewrite bool properties if JSON roundtrip is enabled to allow data binding of those properties in the designer #4351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcam206
approved these changes
Jul 10, 2020
ghost
added
the
|
Hi @dclaux. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Hi @dclaux; Thanks for taking action on your previously stale pull request. Resetting staleness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4261
Description
Data binding support in the designer is currently limited. There are areas where it won't work as expected. A larger work item is planned in the future to bring full, comprehensive dat binding support to the designer, but in the meantime there are quite a few limitations. Binding to boolean properties is (well, was before this PR) one of limitations, but others exist.
With this PR, unset (undefined) boolean properties are not removed anymore from the output payload generated by card.toJSON, which in turn allows for whatever value was in the originally parsed payload to remain in the output (such as a binding expression.)
How Verified
Verified manually in adaptivecards-designer-app
Microsoft Reviewers: Open in CodeFlow