Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusted height anchor constraint #4367

Merged
merged 2 commits into from
Jul 16, 2020
Merged

adjusted height anchor constraint #4367

merged 2 commits into from
Jul 16, 2020

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Jul 13, 2020

Related Issue

Fixed #4349

Description

wrapper view of the image view's height can be bigger than image view sometimes. This is not desirable since the AdaptiveCards scheme does not support vertical alignment as we support horizontal alignment.

How Verified

Image before:
image
Image after:
image

Ran image cards to make sure nothing is broken.

Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft merged commit 0f6a0d5 into main Jul 16, 2020
@jwoo-msft jwoo-msft deleted the jwoo/ios-image-update branch July 16, 2020 07:13
jwoo-msft added a commit that referenced this pull request Jul 31, 2020
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][Image Rendering] Cards are too long when added Image via ResourceResolver
2 participants