[Android] Refactor imageSize methods #4380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcam206
approved these changes
Jul 15, 2020
golddove
added a commit
that referenced
this pull request
Jul 31, 2020
* Refactor imageSize methods * Add test card
golddove
added a commit
that referenced
this pull request
Jul 31, 2020
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Refactor imageSize methods * Add test card
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4364, fixes #4043, fixes #4410 and various other image sizing inconsistencies
Description
Bring Android image sizing/defaults to match JS/iOS/spec.
How Verified
Manual verification.
Payload at
samples/v1.2/Tests/ImageSizing.json.Rendered card:
Microsoft Reviewers: Open in CodeFlow