Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pic2card] Pipeline and Model Enhancements #4434

Merged
merged 1 commit into from Jul 18, 2020
Merged

[pic2card] Pipeline and Model Enhancements #4434

merged 1 commit into from Jul 18, 2020

Conversation

haridas
Copy link
Contributor

@haridas haridas commented Jul 18, 2020

  • Detr model first level results are out.
  • Looking good, but duplicate values are there, have to find way to remove
    it.
  • Measure the mAP score against the benchmark dataset.
  • Voc2coco data convertor.

  • xml_to_csv and generate_tfrecords commands updated.

  • image label has to be synced so that tfrecords are in correct format.
  • xml_to_csv command is now more generic.
  • Notebook update specific for the dataset experiments.
  • Correctly set the category_ids of objects.

  • Faster-RCNN updated hparams

This has been resulted into better validation and test accuracy.
Mainly the tuning has been done with aspect ratios of the image.

  • Added model registry and realted pipelines.
  • Abstract class for the object detection classes
  • We can add multiple implementations and select on for the main
    pipeline
  • Classes are structured with compossibility in mind
  • Inference using libtorch for detr model.

Speed enhancments at inference time.
Helps to reduce the dependency of all python torch library stack.

  • Columns grouping and image size labels

  • columns grouping and image size to labels

  • image size to labels logic

  • removed the check of exact match of number of objects predicted

  • resolved review comments

  • updated the predict json test elements count

  • Standardizing the object detection model pipeline.

  • Helps to switch different object detection models without changing the
    pic2card pipeline.
  • Both Detr and RCNN models are workig with pic2cad.

  • Fixed test cases, to support multiple models.

  • Latest Faster RCNN model frozen dump.

  • Debug api with new bbox draw method.

Model switching are tested using env variable, and test cases are all
passing.

  • Lint fixes and pep8 standardization.

Now only C901 (too complex implementation ) only exempted.

  • Fail build if lint test has problems.

Co-authored-by: Keerthana Manoharan 43063410+Keerthana786@users.noreply.github.com

Microsoft Reviewers: Open in CodeFlow

* Detr model first level results are out.

- Looking good, but duplicate values are there, have to find way to remove
it.
- Measure the mAP score against the benchmark dataset.

* Voc2coco data convertor.

* xml_to_csv and generate_tfrecords commands updated.

- image label has to be synced so that tfrecords are in correct format.
- xml_to_csv command is now more generic.
- Notebook update specific for the dataset experiments.

* Correctly set the category_ids of objects.

* Faster-RCNN updated hparams

This has been resulted into better validation and test accuracy.
Mainly the tuning has been done with aspect ratios of the image.

* Added model registry and realted pipelines.

- Abstract class for the object detection classes
- We can add multiple implementations and select on for the main
pipeline
- Classes are structured with compossibility in mind

* Inference using libtorch for detr model.

Speed enhancments at inference time.
Helps to reduce the dependency of all python torch library stack.

* Columns grouping and image size labels

* columns grouping and image size to labels

* image size to labels logic

* removed the check of exact match of number of objects predicted

* resolved review comments

* updated the predict json test elements count

* Standardizing the object detection model pipeline.

- Helps to switch different object detection models without changing the
pic2card pipeline.

* Both Detr and RCNN models are workig with pic2cad.

* Fixed test cases, to support multiple models.

* Latest Faster RCNN model frozen dump.

* Debug api with new bbox draw method.

Model switching are tested using env variable, and test cases are all
passing.

* Lint fixes and pep8 standardization.

Now only C901 (too complex implementation ) only exempted.

* Fail build if lint test has problems.

Co-authored-by: Keerthana Manoharan <43063410+Keerthana786@users.noreply.github.com>
@Vasanth-S Vasanth-S merged commit b5f311a into microsoft:main Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants