[UWP] Add warning for validated inputs with no error message #4496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almedina-ms
approved these changes
Jul 31, 2020
RebeccaAnne
pushed a commit
that referenced
this pull request
Jul 31, 2020
* [UWP] Add warning for validated inputs with no error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4447
Description
Updated code to return a warning if validation properties are present but the card author has not included an errorMessage.
How Verified
New test file including all input/validation property combos without errorMessages
New unit test validating in code that warnings are returned. Also checked for the warning added for #4385.
Microsoft Reviewers: Open in CodeFlow