[Android][InputEvolution] Fix number input default behaviour #4523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golddove
approved these changes
Aug 4, 2020
|
@almedina-ms please remember to cherry pick this into release/20.07 |
|
@almedina-ms / @golddove, do we have the sample card for this test checked in ? If not please let;s get it in. |
almedina-ms
deleted the
user/almedina-ms/IE_Android_FixNumberInputRendering
branch
almedina-ms
added a commit
that referenced
this pull request
Aug 4, 2020
Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
shalinijoshi19
added a commit
that referenced
this pull request
Aug 5, 2020
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4522
Description
This fix changes the comparisson behaviours to match the new use of nullable properties for value, min and max in Input.Number. Now there are null checks instead of comparissons against Integer.MIN_VALUE or Integer.MAX_VALUE constants.
How Verified
The fix was verified manually and the results can be seen below:
Value set, Min/Max null/unset
Value null/unset
Microsoft Reviewers: Open in CodeFlow