[Android] Add tests for validators #4556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…//github.com/microsoft/AdaptiveCards into user/almedina-ms/IE_AndroidValidationTesting
|
If this PR has fixes for other issues, can you please reference those in the description here for proper correlation? Thanks |
Ideally try to avoid bundling in different unrelated commits in a single one. And if you do, pls do make sure the PR title/description reflects that :) Eg this looks to be many more fixes and not just new unit tests that have been added. Do ensure the PR title reflects this. |
shalinijoshi19
approved these changes
Aug 17, 2020
...ivecards/src/androidTest/java/io/adaptivecards/objectmodel/ChoiceSetInputPropertiesTest.java
Outdated
Show resolved
Hide resolved
...ivecards/src/androidTest/java/io/adaptivecards/objectmodel/ChoiceSetInputPropertiesTest.java
Outdated
Show resolved
Hide resolved
...ivecards/src/androidTest/java/io/adaptivecards/objectmodel/ChoiceSetInputPropertiesTest.java
Outdated
Show resolved
Hide resolved
...ivecards/src/androidTest/java/io/adaptivecards/objectmodel/ChoiceSetInputPropertiesTest.java
Outdated
Show resolved
Hide resolved
...adaptivecards/src/androidTest/java/io/adaptivecards/objectmodel/DateInputPropertiesTest.java
Outdated
Show resolved
Hide resolved
...aptivecards/src/androidTest/java/io/adaptivecards/objectmodel/NumberInputPropertiesTest.java
Outdated
Show resolved
Hide resolved
...e/android/adaptivecards/src/main/java/io/adaptivecards/renderer/input/TimeInputRenderer.java
Show resolved
Hide resolved
...d/adaptivecards/src/main/java/io/adaptivecards/renderer/inputhandler/NumberInputHandler.java
Show resolved
Hide resolved
...d/adaptivecards/src/main/java/io/adaptivecards/renderer/inputhandler/NumberInputHandler.java
Show resolved
Hide resolved
...oid/adaptivecards/src/main/java/io/adaptivecards/renderer/inputhandler/TimeInputHandler.java
Show resolved
Hide resolved
…//github.com/microsoft/AdaptiveCards into user/almedina-ms/IE_AndroidValidationTesting
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Add validation testing for number and text input * Add tests for all input handlers * Update input handlers to fix invalid inputs * Update test files * Update invaluid values for tests * Update invalid cases * Refactor date input tests * Refactor number validation tests * Refactor TimeInput validation tests * Refactor toggle input tests * Refactor choiceSet tests * Fix small stuff * Cleanup some unnnecesary imports * Refactor input text tests * Fix comments Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4554
Description
Adds unit tests for all validation types in android.
Fixes in other places:
How Verified
This includes a lot of unit tests so it verifies itself
Microsoft Reviewers: Open in CodeFlow