Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Reset state for other actions in ActionSet on ShowCard click #4566

Merged
merged 2 commits into from
Aug 18, 2020

Conversation

almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented Aug 11, 2020

Related Issue

Fixes #4548

Description

Reset the state of all sibling buttons when a ShowCard action receives an onClick event. This makes all other cards reset their chevron

How Verified

The fix was verified manually as can be seen below:

resetChevron

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Aug 16, 2020

Hi @almedina-ms. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Aug 17, 2020
@ghost
Copy link

ghost commented Aug 17, 2020

Hi @golddove; Thanks for reviewing this previously stale pull request. Resetting staleness. @almedina-ms FYI.

@almedina-ms almedina-ms merged commit 4811cbf into main Aug 18, 2020
@almedina-ms almedina-ms deleted the user/almedina-ms/Android_ResetChevronOnClick branch August 18, 2020 18:30
almedina-ms added a commit that referenced this pull request Aug 28, 2020
jwoo-msft pushed a commit that referenced this pull request Aug 29, 2020
jwoo-msft pushed a commit that referenced this pull request Aug 31, 2020
* Reset all other views (#4566)

* Fix build error
jwoo-msft added a commit that referenced this pull request Aug 31, 2020
* Reset all other views (#4566)

* cherry-picked ios showcard button state change

* Android chevron fix cherry-pick (#4697)

* Reset all other views (#4566)

* Fix build error

* Fix build breaj

Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com>
Co-authored-by: Alberto Medina Gutierrez <almedina@microsoft.com>
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mobile][Usability] [Chevron no reset issue in Action.ShowCards ]
2 participants