Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Designer] Copy bound card #4592

Merged
merged 2 commits into from
Aug 17, 2020
Merged

[Designer] Copy bound card #4592

merged 2 commits into from
Aug 17, 2020

Conversation

dclaux
Copy link
Member

@dclaux dclaux commented Aug 14, 2020 •
edited by ghost

Related Issue

Fixes #4579
Fixes #4563

Description

  • Designer
    • "Copy Card JSON" button now labeled "Copy card payload" and now has a tooltip describing what it does
    • "Copy card payload" now copies the bound card and not just the template. To copy the template payload, select all in the Card Payload Editor and hit CTRL+C
  • Renderer
    • No more warning when Image.height is set to "auto" or "stretch"

How Verified

Verified manually in adaptivecards-designer-app

Microsoft Reviewers: Open in CodeFlow

@dclaux
[Designer] Copy bound card
77551f9 
[Renderer] Remove warning for Image.height == "auto"
@ghost
Copy link

ghost commented Aug 14, 2020

Hi @dclaux. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

matthidinger
matthidinger approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@matthidinger matthidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks David!

@dclaux dclaux merged commit b94e494 into main Aug 17, 2020
@dclaux dclaux deleted the ts/designer-copy-json branch August 17, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthidinger matthidinger matthidinger approved these changes

@paulcam206 paulcam206 Awaiting requested review from paulcam206

@golddove golddove Awaiting requested review from golddove

@shalinijoshi19 shalinijoshi19 Awaiting requested review from shalinijoshi19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dclaux @matthidinger