Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Bump target SDK to 28 #4605

Merged
merged 9 commits into from
Aug 20, 2020
Merged

[Android] Bump target SDK to 28 #4605

merged 9 commits into from
Aug 20, 2020

Conversation

golddove
Copy link
Member

@golddove golddove commented Aug 17, 2020

Related Issue

Fixes #4501
Will stop dependabot from complaining :) PR's #4070, #4072, #4074

Description

Bump Android SDK to 28

Caused two regressions, so those fixes are included in this PR.

  • ActionSet's failed to show their children
  • Images failed to load due to Android security permission changes

How Verified

Manually compared all Element and Scenario cards in v1.0 to v1.3 for regressions

Microsoft Reviewers: Open in CodeFlow

@golddove golddove merged commit f091484 into main Aug 20, 2020
@golddove golddove deleted the golddove/android-28 branch August 20, 2020 18:33
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
* Bump to sdk 28

* Fix ActionSet issue

* Allow http traffic in sample apps

* Remove deprecated import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Bump target sdk to 28
2 participants