Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP][Tests] Update expected json files for TestAllCards unit test #4645

Merged
merged 6 commits into from
Aug 26, 2020

Conversation

RebeccaAnne
Copy link
Contributor

@RebeccaAnne RebeccaAnne commented Aug 24, 2020

Related Issue

Partial fix for #4624

Description

The TestAllCards test depends on files containing the expected result for json round-tripping. Those files had gotten out of date, leading to test failures. Updated those files using the test app. Also logged #4644 to get the UWP tests into CI. I did not update the image files for the test app, as the test app doesn't render as expected on my laptop monitor per a warning from the app.

How Verified

TestAllCards test now passes when the Column.Fallback.json (#4627) and AdaptiveCard.BackgroundImage.DataUri.json (#4641) cards are excluded.

Microsoft Reviewers: Open in CodeFlow

@RebeccaAnne RebeccaAnne merged commit 5b5408f into main Aug 26, 2020
@RebeccaAnne RebeccaAnne deleted the rebecch/fixRunAllTests branch August 26, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants