Ensure image source has been set before calling BitmapSource::SetSourceAsync #4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lls to IImage::get_Source do not succeed but return a null source.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4651
Description
A previous PR #4225 updated the XAML image loading code to use the asynchronous BitmapSource::SetSourceAsync function in order to improve rendering performance. This had the unintended side effect of causing the background image loading code to crash as it assumed IImage::get_Source cannot return a null pointer. To avoid the crash the image source is now set before calling BitmapSource::SetSourceAsync.
How Verified
The fix was verified through manual testing of the Cortana in Windows application.
Microsoft Reviewers: Open in CodeFlow