Make ParseUtil::JsonToString thread safe #4654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uilder instance const and thread_local.
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
…uilder instance const and thread_local. (microsoft#4654) Co-authored-by: RebeccaAnne <rebecch@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolves #4653
Description
After updating the Cortana in Windows app from version 1.2.0 to 2.0.0 of the UWP adaptive cards renderer repeated crashes in ParseUtil::JsonToString were observed. It has been speculated that one thread is modifying the static Json::StreamWriterBuilder instance's properties while another is using it to construct a new stream writer. Updating the code so that the static instance is const and thread_local appears to resolve the issue.
How Verified
Manual testing of the Cortana in Windows application.
Microsoft Reviewers: Open in CodeFlow