Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pic2card] Stabilizing columns grouping #4656

Merged
merged 1 commit into from Aug 25, 2020
Merged

[pic2card] Stabilizing columns grouping #4656

merged 1 commit into from Aug 25, 2020

Conversation

Keerthana786
Copy link
Contributor

@Keerthana786 Keerthana786 commented Aug 25, 2020

  • Reduced the number of thresholds used for column-set and columns grouping.
  • Used horizontal and vertical inclusive logic to group the objects into a column-set or column.
  • Changes in noise removal : along with the IOU based removal , the smaller objects [ in overlapping scenarios] which covers more than 50% of the intersection area will also be removed.
  • Changed the columns and column-set alignment logic of doing max of count of the alignments to choose from a predefined order - Left, Center, Right in cases where the alignments of the objects are unique.
    • for example: if a column as 2 elements with ["Right", "Left"] as alignments, on doing max of count will pick different alignment each time, instead changed the logic to choose in the predefined order in case of unique alignments.
    • So if the alignments of the objects are ["Right", "Center"] in a column , then the column's alignment will be Center.
  • Removed the redundant call made to get_objects method in debug API to one.
Microsoft Reviewers: Open in CodeFlow

* columns grouping stabilization

* removed 2 calls for get_objects in debug api
@Keerthana786 Keerthana786 changed the title Stabilizing columns grouping (#29) Stabilizing columns grouping Aug 25, 2020
@Keerthana786 Keerthana786 changed the title Stabilizing columns grouping [pic2card] Stabilizing columns grouping Aug 25, 2020
@Vasanth-S Vasanth-S self-requested a review August 25, 2020 16:25
@Vasanth-S Vasanth-S merged commit aae0c87 into microsoft:main Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants