Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Evaluation function used for expanding json #4659

Merged
merged 4 commits into from
Aug 27, 2020

Conversation

almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented Aug 25, 2020

Related Issue

Fixes #4574
But opens #4646

Description

Changes the use of the evaluation function to remove the enclosing braces and add an equals sign "=" to evaluate the actions based on the guidance of the AEL team. For example, "${sort(createArray(2,1))}" is converted into "=sort(createArray(2,1))"

How Verified

The fix was verified adding an unit test that contains the same payload that originated the issue. If the json expansion were to fail it would throw an exception

Microsoft Reviewers: Open in CodeFlow

@almedina-ms almedina-ms added this to the 20.08 milestone Aug 25, 2020
@almedina-ms almedina-ms merged commit 8830aab into main Aug 27, 2020
@almedina-ms almedina-ms deleted the user/almedina-ms/Templating_FixFunctionInData branch August 27, 2020 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Templating] Adaptive Cards pre-built functions are not working within $data construct
2 participants