Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump constraint-layout from 1.1.3 to 2.0.1 in /source/android #4664

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Aug 26, 2020

Bumps constraint-layout from 1.1.3 to 2.0.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @almedina-ms.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)
Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Aug 31, 2020

Hi @dependabot-preview[bot]. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/gradle/source/android/com.android.support.constraint-constraint-layout-2.0.1 branch from 70fa03c to c9b9b78 Compare August 31, 2020 22:36
@ghost ghost removed the no-recent-activity label Aug 31, 2020
@ghost
Copy link

ghost commented Aug 31, 2020

Hi @dependabot-preview[bot]; Thanks for taking action on your previously stale pull request. Resetting staleness.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/gradle/source/android/com.android.support.constraint-constraint-layout-2.0.1 branch 2 times, most recently from 3ffac1d to 59c211f Compare September 1, 2020 22:55
@ghost ghost added the no-recent-activity label Sep 7, 2020
@ghost ghost assigned RebeccaAnne Sep 7, 2020
@ghost
Copy link

ghost commented Sep 7, 2020

Hi @dependabot-preview[bot]. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@RebeccaAnne
Copy link
Contributor

@almedina-ms @golddove could one of you take a look at this one?

@ghost ghost removed the no-recent-activity label Sep 8, 2020
@ghost
Copy link

ghost commented Sep 8, 2020

Hi @RebeccaAnne; Thanks for commenting on this previously stale pull request. Resetting staleness. @dependabot-preview[bot] FYI.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/gradle/source/android/com.android.support.constraint-constraint-layout-2.0.1 branch from 59c211f to 21328f2 Compare September 8, 2020 17:34
@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@almedina-ms
Copy link
Contributor

I think we should do a smoke test pass to see that all cards keep rendering correctly with this change

Bumps constraint-layout from 1.1.3 to 2.0.1.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/gradle/source/android/com.android.support.constraint-constraint-layout-2.0.1 branch from 21328f2 to 9e9e464 Compare September 9, 2020 14:41
@dependabot-preview dependabot-preview bot merged commit dc01f5b into main Sep 9, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/gradle/source/android/com.android.support.constraint-constraint-layout-2.0.1 branch September 9, 2020 15:03
@golddove
Copy link
Member

We did not test the ImageSizing.json payload. Only ran through the standard Scenario samples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants