Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Samples][Accessibility] Remove titles from selectActions #4669

Merged
merged 4 commits into from
Sep 3, 2020

Conversation

golddove
Copy link
Member

@golddove golddove commented Aug 26, 2020

Related Issue

ADO 24110322
ADO 24095001
ADO 24096164

Description

Explicit titles are unnecessary for selectAction's on containers as long as the containers contents are read properly by a Screen Reader.

Split FlightDetails actions to two ActionSet's to avoid overflow.

How Verified

Manual verification

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the no-recent-activity label Sep 3, 2020
@ghost ghost assigned dclaux Sep 3, 2020
@ghost
Copy link

ghost commented Sep 3, 2020

Hi @golddove. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Sep 3, 2020
@ghost
Copy link

ghost commented Sep 3, 2020

Hi @golddove; Thanks for taking action on your previously stale pull request. Resetting staleness.

@paulcam206 paulcam206 merged commit 83e3b59 into main Sep 3, 2020
@paulcam206 paulcam206 deleted the golddove/samples branch September 3, 2020 23:08
@golddove golddove added this to the 20.09 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants