[Samples] Update scenario samples to ensure match between templated and non-templated versions #4695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 28, 2020 14:44
…nd non-templated versions
paulcam206
approved these changes
Aug 31, 2020
almedina-ms
reviewed
Aug 31, 2020
| @@ -160,7 +160,7 @@ | |||
| "items": [ | |||
| { | |||
| "type": "TextBlock", | |||
| "text": "November 12, 2017", | |||
| "text": "Sat, Mar 4, 2017", | |||
There was a problem hiding this comment.
Shouldn't we have to update this textblocks to use {Date} formatting in the string? Seems like we're missing an opportunity here
There was a problem hiding this comment.
@almedina-ms with @RebeccaAnne out can you pick up where she left off here to shepherd this change in? Thanks!
There was a problem hiding this comment.
I think we should probably fix the date stuff later rather than hold up the release. I'll file a new issue.
paulcam206
added a commit
that referenced
this pull request
Aug 31, 2020
…nd non-templated versions (#4695) * [Samples] Update scenario samples to ensure match between templated and non-templated versions * Fix error * Fix WeatherLarge.json line endings Co-authored-by: Paul Campbell <paulcam@microsoft.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4578
Description
Updated scenario samples to match the templated and non-templated versions.
How Verified
Ensured all modified samples rendered as expected.
Microsoft Reviewers: Open in CodeFlow