Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site] Adjust color contrast for a couple of borders #4725

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

paulcam206
Copy link
Member

@paulcam206 paulcam206 commented Sep 2, 2020

Related Issue

Fixes VSO 24066126

Description

There are a couple of borders which fail to meet MAS 1.4.11's 3:1 contrast ratio requirement:

image
image

This change tweaks the borders to be dark enough to hit the 3:1 requirement:

image
image

How Verified

  • local build and color contrast testing tools
Microsoft Reviewers: Open in CodeFlow

@paulcam206 paulcam206 added the Area-Accessibility Bugs around feature accessibility label Sep 2, 2020
@ghost
Copy link

ghost commented Sep 2, 2020

Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@paulcam206 paulcam206 merged commit d4adbf1 into main Sep 3, 2020
@paulcam206 paulcam206 deleted the paulcam/color-contrast branch September 3, 2020 17:58
paulcam206 added a commit that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Bugs around feature accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant