[JS] Emit "invisible" borders for containers #4727
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes VSO 24095690
Description
When a user puts their system in high contrast mode, their user agent will override CSS properties in order to display content in the same high contrast mode. There's no way for us (the website) to know if this is happening. The user will of course lose some of our styling cues (e.g.
TextBlock
'scolor
property). This is expected, but we are losing one critical bit of useful visual state -- container borders.Here's what our
Container
sample card looks like:The fix on our end is to emit an "invisible" border on containers (specifically, we emit a 1px solid border that is the same color as the container's
backgroundColor
). Here's how it looks with our fix:How Verified
Microsoft Reviewers: Open in CodeFlow