[Samples] Update FlightDetails sample to have more logical reading order #4736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcam206
requested review from
dclaux,
matthidinger,
golddove,
RebeccaAnne,
almedina-ms and
shalinijoshi19
RebeccaAnne
reviewed
Sep 8, 2020
| "text": "Sat, Mar 4, 2017", | ||
| "isSubtle": true, | ||
| "wrap": true | ||
| "type": "RichTextBlock", |
There was a problem hiding this comment.
RichTextBlock [](start = 22, length = 13)
Do we have (or plan to have) a customer facing document on how to make sure your cards are accessible? This seems like something we should capture in a tips and tricks kind of way to encourage others to avoid this pitfall.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes VSO 24096000
Description
Update the FlightDetails sample to use a
RichTextBlockin a single set ofColumnSets so that screenreaders can give a more reasonable reading experience. Prior to this, rather than reading down a column, Narrator would read left to right and top to bottom (i.e. it would read SFO's time then JFK's time, then SFO's date, then JFK's date etc.)How Verified
Microsoft Reviewers: Open in CodeFlow