Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PlaceHolder Text #4754

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Sep 9, 2020

Related Issue

Fixed #4672

Description

Updated single and multiline Input.Text text color to placeholderTextColor for better accessibility.

How Verified

How you verified the fix, including one or all of the following:

  1. Visually examined existing Input.Text with a placeholder that it has the update text color.
Microsoft Reviewers: Open in CodeFlow

@almedina-ms almedina-ms self-requested a review September 9, 2020 23:47
@shalinijoshi19
Copy link
Member

@jwoo-msft is this related to any existing ADO issue filed by the Accessibility test team at all? If so couldyou pls reference the issue link here tx

@jwoo-msft jwoo-msft merged commit 7c6ea41 into main Sep 11, 2020
@jwoo-msft jwoo-msft deleted the jwoo/ios-placeholder-text-color-update branch September 11, 2020 17:54
@jwoo-msft
Copy link
Member Author

@shalinijoshi19 There are no related existing ADO issues as the tests have not run on input cards.

@golddove golddove added this to the 20.09 milestone Mar 3, 2021
rankush pushed a commit to rankush/AdaptiveCards that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][Accessibility] ACRTextView placeholder text color too light
5 participants