-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Samples] Update restaurant sample to read more naturally for a11y #4762
Conversation
"priceRange": "mid-priced" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how they make google maps accessible, I've seen the $ or $$$ model work before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, we would need to add some mechanism for authors to specify alternative text.
Could potentially be solved if/when we figure out tooltips on all elements? Not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, i agree. We should probably have something tracking figuring out alt-text on Text elements for this kind of scenario.
In reply to: 485986018 [](ancestors = 485986018)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filed #4764 to track
@@ -23,13 +23,13 @@ | |||
}, | |||
{ | |||
"type": "TextBlock", | |||
"text": "4.5 ★★★★★ (176) · $$", | |||
"text": "4.5 stars (176 reviews) · mid-priced", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to investigate if we can extend the extensibility to be able to deal with this kind of scenarios
https://stackoverflow.com/questions/55966205/star-rating-component-what-are-the-correct-accessibility-and-semantics-to-be-u
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
filed #4764 to track :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related Issue
Fixes VSO 23712499
Description
The use of symbols rather than text leads to a suboptimal story for accessibility. Here we move to a more text-based model for the restaurant sample cards.
How Verified
Microsoft Reviewers: Open in CodeFlow