Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Samples] Update restaurant sample to read more naturally for a11y #4762

Merged
merged 3 commits into from
Sep 10, 2020

Conversation

paulcam206
Copy link
Member

@paulcam206 paulcam206 commented Sep 9, 2020

Related Issue

Fixes VSO 23712499

Description

The use of symbols rather than text leads to a suboptimal story for accessibility. Here we move to a more text-based model for the restaurant sample cards.

How Verified

  • Local build & narrator
Microsoft Reviewers: Open in CodeFlow

@paulcam206 paulcam206 added Area-Accessibility Bugs around feature accessibility Area-Samples Fixes related to our test samples labels Sep 9, 2020
@paulcam206 paulcam206 marked this pull request as ready for review September 9, 2020 22:32
"priceRange": "mid-priced"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how they make google maps accessible, I've seen the $ or $$$ model work before

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we would need to add some mechanism for authors to specify alternative text.

Could potentially be solved if/when we figure out tooltips on all elements? Not sure.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, i agree. We should probably have something tracking figuring out alt-text on Text elements for this kind of scenario.


In reply to: 485986018 [](ancestors = 485986018)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filed #4764 to track

@@ -23,13 +23,13 @@
},
{
"type": "TextBlock",
"text": "4.5 ★★★★★ (176) · $$",
"text": "4.5 stars (176 reviews) · mid-priced",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to investigate if we can extend the extensibility to be able to deal with this kind of scenarios
https://stackoverflow.com/questions/55966205/star-rating-component-what-are-the-correct-accessibility-and-semantics-to-be-u

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filed #4764 to track :)

Copy link
Contributor

@RebeccaAnne RebeccaAnne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@paulcam206 paulcam206 merged commit 3f46e4e into main Sep 10, 2020
@paulcam206 paulcam206 deleted the paulcam/restaurant-sample branch September 10, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Bugs around feature accessibility Area-Samples Fixes related to our test samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants