Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Site][Accessibility] Change h5 to p #4769

Merged
merged 1 commit into from
Sep 11, 2020
Merged

[Site][Accessibility] Change h5 to p #4769

merged 1 commit into from
Sep 11, 2020

Conversation

golddove
Copy link
Member

@golddove golddove commented Sep 11, 2020 •
edited by ghost

Related Issue

ADO 24130051

Description

This text is not header text, so removing h5 tag.

How Verified

Manual verification

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Sep 11, 2020

Hi @golddove. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@paulcam206 paulcam206 merged commit 9e804de into main Sep 11, 2020
@paulcam206 paulcam206 deleted the golddove/24130051 branch September 11, 2020 23:57
@golddove golddove added this to the 20.09 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcam206 paulcam206 paulcam206 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@golddove @paulcam206