-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Sample][Accessibility] Reply button icon update #4774
Conversation
Looks good to me; Looks like the following additional changes requested by the Accessibility SMEs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional changes/specifics requested by the E+D folks.
"text": "Text input with an inline action" | ||
}, | ||
{ | ||
"type": "Input.Text", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you repeated the single line input elements here, you should remove them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update multiline sample
Signing off at my end pursuant to addressing comments by others/ @almedina-ms ..Tx! |
Related Issue
ADO 24043965
Description
For 'reply' selectAction, use a representative icon instead of cat image.
Sourced from Microsoft Brand Central's Microsoft 365 illustrations.
How Verified
Manual verification
Microsoft Reviewers: Open in CodeFlow