Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample][Accessibility] Reply button icon update #4774

Merged
merged 11 commits into from
Sep 25, 2020
Merged

Conversation

golddove
Copy link
Member

@golddove golddove commented Sep 14, 2020

Related Issue

ADO 24043965

Description

For 'reply' selectAction, use a representative icon instead of cat image.

Sourced from Microsoft Brand Central's Microsoft 365 illustrations.

How Verified

Manual verification

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Sep 14, 2020

Hi @golddove. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@shalinijoshi19
Copy link
Member

Looks good to me; Looks like the following additional changes requested by the Accessibility SMEs:
for different reply button please add screen reader name like below for each reply button:

  1. Text input Reply button
  2. Text input no icon Reply button
  3. Multiline text input reply button.

Copy link
Member

@shalinijoshi19 shalinijoshi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional changes/specifics requested by the E+D folks.

@shalinijoshi19 shalinijoshi19 added AdaptiveCards v20.09 Area-Accessibility Bugs around feature accessibility Area-Samples Fixes related to our test samples labels Sep 18, 2020
@shalinijoshi19 shalinijoshi19 modified the milestone: 20.09 Sep 18, 2020
@ghost ghost removed the AdaptiveCards v20.09 label Sep 21, 2020
@shalinijoshi19 shalinijoshi19 added this to the 20.09 milestone Sep 23, 2020
@shalinijoshi19 shalinijoshi19 modified the milestone: 20.09 Sep 23, 2020
@ghost ghost added the AdaptiveCards v20.09 label Sep 23, 2020
@ghost ghost removed the Needs: Author Feedback label Sep 25, 2020
"text": "Text input with an inline action"
},
{
"type": "Input.Text",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you repeated the single line input elements here, you should remove them

Copy link
Contributor

@almedina-ms almedina-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update multiline sample

@shalinijoshi19
Copy link
Member

Signing off at my end pursuant to addressing comments by others/ @almedina-ms ..Tx!

@golddove golddove merged commit 36426a2 into main Sep 25, 2020
@golddove golddove deleted the golddove/24043965 branch September 25, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Bugs around feature accessibility Area-Samples Fixes related to our test samples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants