Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4767
Fixes #4734
References #4483
Description
toJSON()
is automatically invoked viaJSON.stringify()
, it gets a parameter of typestring
. The AC renderer's implementation oftoJSON()
takes an optional parameter of typeBaseSerializationContext
. When the value of this parameter is notundefined
, the code assumes it is of typeBaseSerializationContext
which is not the case whentoJSON()
is invoked viaJSON.stringify()
, and thus generates an exception. This PR fixes that by checking the type of the parametertoJSON()
receives.wrap
property set totrue
by defaultHow Verified
Verified manually in adaptivecards-designer-app and test site
Microsoft Reviewers: Open in CodeFlow