Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Update hostconfig container colors in script.js file #4806

Merged

Conversation

almedina-ms
Copy link
Contributor

@almedina-ms almedina-ms commented Sep 23, 2020

Related Issue

ADO 24094745

Description

Changes the colors in script.js file to match the colors we had modified in the host config samples. The website uses the colors defined in this file rather than the ones in the hostconfig files under the samples folder

Validation

The fix was verified checking the pr website

image

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Sep 23, 2020

Hi @almedina-ms. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@shalinijoshi19
Copy link
Member

@matthidinger could you take a 2nd look real quick on this? Thanks!

@almedina-ms almedina-ms merged commit ee22c65 into main Sep 23, 2020
@almedina-ms almedina-ms deleted the user/almedina-ms/Website_UpdateSampleContainerColors branch September 23, 2020 22:01
@golddove golddove added this to the 20.09 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants