Added Placeholder to ChoiceSet #4811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was an error handling pipeline event 820873f4-824a-4ff9-a38f-0a2886cb9a58. |
…aptiveCards into jwoo/choice-set-placeholder
matthidinger
requested changes
Sep 24, 2020
| @@ -20,10 +20,14 @@ | |||
| "type": "string", | |||
| "description": "The initial choice (or set of choices) that should be selected. For multi-select, specify a comma-separated string of values." | |||
| }, | |||
| "placeholder": { | |||
| "type": "string", | |||
| "description": "Description of the input desired. Displayed when no selection has been made, style is compact and multi selection is false." | |||
There was a problem hiding this comment.
Thanks for adding this Joseph! Can you tweak the format a bit, something like: "Description of the input desired. Only visible when no selection has been made, the style is compact and isMultiSelect is false." #Resolved
There was a problem hiding this comment.
ghost
added
the
almedina-ms
approved these changes
Sep 25, 2020
almedina-ms
requested changes
Sep 25, 2020
|
thanks In reply to: 496028907 [](ancestors = 496028907) |
…aptiveCards into jwoo/choice-set-placeholder
Could we get a simple sample card that uses this? If we put it in the Elements directory and name it Input.ChoiceSet.Placeholder.json it can serve as a website sample as well. #Resolved Refers to: schemas/src/elements/inputs/Input.ChoiceSet.json:1 in 90f7904. [](commit_id = 90f7904, deletion_comment = False) |
almedina-ms
approved these changes
Sep 28, 2020
…aptiveCards into jwoo/choice-set-placeholder
matthidinger
approved these changes
Sep 29, 2020
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Fixed the crash issue * Fixed Bleeding Crash Issue * finishing up changes for bleed update * work in progress * updated ChoiceSetInput.cpp * ios change * schema & uwp changes * Updated specs * Android Changes * addressed review comments * Updated specs * Added placeholder text example to test cards * added a new card * added UWP test images * Fixed bad merge * updated schema * Updated specs Co-authored-by: Adaptive Cards Specs CI <donotreply@microsoft.com> Co-authored-by: almedina-ms <35784165+almedina-ms@users.noreply.github.com> Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
reference #3885
Fixes #4810
Description
Added placeholder text for Input.ChoiceSet when it is single select and compact style.
How Verified
How you verified the fix, including one or all of the following:
Microsoft Reviewers: Open in CodeFlow