[.Net HTML]fix IgnoreDefaultStringEnumConverter NullReference issue #4833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
shalinijoshi19
approved these changes
Oct 7, 2020
ghost
added
the
|
Hi @TonyLi2013. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Hi @TonyLi2013; Thanks for taking action on your previously stale pull request. Resetting staleness. |
|
I'm new to GitHub, I wonder the next step with this PR since it became no-recent-activity. If this can be Merged by your side? @shalinijoshi19 Thanks in advance. |
|
Hi @TonyLi2013. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Hi @TonyLi2013; Thanks for taking action on your previously stale pull request. Resetting staleness. |
shalinijoshi19
approved these changes
Dec 18, 2020
|
Hello @shalinijoshi19! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
jwoo-msft
pushed a commit
that referenced
this pull request
Jan 20, 2021
…4833) ## Related Issue Fixes #4831 ## Description Avoid NullReferenceException while the enum is null in JSON string 
jwoo-msft
added a commit
that referenced
this pull request
Jan 23, 2021
* Updated ImageView constraints * updated intrinsic content size * reverted build optimazation settings * [Site] Fix missing expression library dep (#5194) * expression library rc to 4.11.0 * Add expression library to site footer scripts * Updating Readme to reflect binary license updates With our 20.12 release we are fixing a long running bug, where we were shipping our binary packages under the MIT license inadvertently. The MIT license only applies to open source and not shipping binaries which are now governed by our new End User License Agreement for AdaptiveCards. * Quick verbiage change in the EULA section * More license terms explanation verbiage * [.Net HTML]fix IgnoreDefaultStringEnumConverter NullReference issue (#4833) ## Related Issue Fixes #4831 ## Description Avoid NullReferenceException while the enum is null in JSON string  * columnset alignment to fill, and added spacer for factset * work in progress * work in progress * Mostly work except background images * removed the wrapperview * refactoring * refactoring complete // need unit tests and optimazation * fixed stretch issues * Finished fixing small/medium/large images sizes * Added UnitTests * cleaned up the code * complete * fixed ci failures * revert project file changes * chaged made after review comments Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com> Co-authored-by: Tony <lxtx.ljb@163.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Updated ImageView constraints * updated intrinsic content size * reverted build optimazation settings * [Site] Fix missing expression library dep (microsoft#5194) * expression library rc to 4.11.0 * Add expression library to site footer scripts * Updating Readme to reflect binary license updates With our 20.12 release we are fixing a long running bug, where we were shipping our binary packages under the MIT license inadvertently. The MIT license only applies to open source and not shipping binaries which are now governed by our new End User License Agreement for AdaptiveCards. * Quick verbiage change in the EULA section * More license terms explanation verbiage * [.Net HTML]fix IgnoreDefaultStringEnumConverter NullReference issue (microsoft#4833) ## Related Issue Fixes microsoft#4831 ## Description Avoid NullReferenceException while the enum is null in JSON string  * columnset alignment to fill, and added spacer for factset * work in progress * work in progress * Mostly work except background images * removed the wrapperview * refactoring * refactoring complete // need unit tests and optimazation * fixed stretch issues * Finished fixing small/medium/large images sizes * Added UnitTests * cleaned up the code * complete * fixed ci failures * revert project file changes * chaged made after review comments Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com> Co-authored-by: Tony <lxtx.ljb@163.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4831
Description
Avoid NullReferenceException while the enum is null in JSON string
Microsoft Reviewers: Open in CodeFlow