Spec for column vs image size #4887
Conversation
@almedina-ms can you update the description on this PR and remove the template placeholder text? Thanks |
|
|
||
| ### Current problem | ||
|
|
||
| As part of the solution to the Column width behaviour it was thought that images could be used as a reference to provide the minimum size needed to render an `auto` width column. This asseveration is not correct, as some of our scenario cards don't follow that principle, take for example the [FlightDetails card](), in this card we have an image whose `width` is `1000px`, if we were to honour the measurements given by the card author we would get a card where this long image occupies most of the width of the column set as can be seen in the views generated by the iOS and the Android renderers. |
There was a problem hiding this comment.
Thanks for trying to add context here. But can you also link to the "Column width behavior" issue that you are referring to here for clarification? Thanks
|
|
||
| ### Current problem | ||
|
|
||
| As part of the solution to the Column width behaviour it was thought that images could be used as a reference to provide the minimum size needed to render an `auto` width column. This asseveration is not correct, as some of our scenario cards don't follow that principle, take for example the [FlightDetails card](), in this card we have an image whose `width` is `1000px`, if we were to honour the measurements given by the card author we would get a card where this long image occupies most of the width of the column set as can be seen in the views generated by the iOS and the Android renderers. |
There was a problem hiding this comment.
NitNit: :) I had to look up the dictionary for that one :) - Could we use 'assumption' here?
|
|
||
| ### Current problem | ||
|
|
||
| As part of the solution to the Column width behaviour it was thought that images could be used as a reference to provide the minimum size needed to render an `auto` width column. This asseveration is not correct, as some of our scenario cards don't follow that principle, take for example the [FlightDetails card](), in this card we have an image whose `width` is `1000px`, if we were to honour the measurements given by the card author we would get a card where this long image occupies most of the width of the column set as can be seen in the views generated by the iOS and the Android renderers. |
There was a problem hiding this comment.
| As part of the solution to the Column width behaviour it was thought that images could be used as a reference to provide the minimum size needed to render an `auto` width column. This asseveration is not correct, as some of our scenario cards don't follow that principle, take for example the [FlightDetails card](), in this card we have an image whose `width` is `1000px`, if we were to honour the measurements given by the card author we would get a card where this long image occupies most of the width of the column set as can be seen in the views generated by the iOS and the Android renderers. | |
| As part of the solution to the Column width behavior it was thought that images could be used as a reference to provide the minimum size needed to render an `auto` width column. This assumption is not correct as some of our scenario cards don't follow that principle. Take for example the [FlightDetails card](), where we have an image whose `width` is `1000px`; If we were to honor the measurements given by the card author we would get a card where this long image occupies most of the width of the column set as can be seen in the views generated by the iOS and the Android renderers. |
|
|
||
| | Rendered view | Schema | ||
| | --- | --- | | ||
| | <img src="assets/ImageColumn/BadFlightDetails.png" width="800px"> | <img src="assets/ImageColumn/BadRenderSchema.png" width="800px"> | |
There was a problem hiding this comment.
This results in a 404.. Does this need to include the relative path here vis "../assets"?
ghost
added
the
|
Hi @almedina-ms. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Hi @almedina-ms; Thanks for taking action on your previously stale pull request. Resetting staleness. |
Related Issue
Please use one of the well-known github fixes keywords to reference
the issues fixed with this PR (eg Fixes #). If an issue doesn't yet exist please create one if reasonable to aid
in issue tracking.
NOTE: For multiple issues resolved by this PR use the corresponding keywords every time in a comma-delimited list per the reference
page above.
Description
Create a descriptive title and provide all of the relevant details in the description.
This information lives with the code and will help future readers (including yourself) and will serve as documentation.
At the very least please describe the issue you are addressing, and what your fix entails.
How Verified
How you verified the fix, including one or all of the following:
will aid in code reviews or corresponding fixes on other platforms for eg.
Microsoft Reviewers: Open in CodeFlow