Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Update the schema documentation for TextRun to explicitly call out text shorthand #4910

Merged
merged 11 commits into from
Oct 27, 2020

Conversation

RebeccaAnne
Copy link
Contributor

@RebeccaAnne RebeccaAnne commented Oct 12, 2020

Related Issue

Fixes #4183

Description

Per discussion in linked issue updating the documentation for TextRuns to ensure that the shorthand form that is equivalent to the object form is clearly called out.

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the no-recent-activity label Oct 19, 2020
@ghost ghost assigned dclaux Oct 19, 2020
@ghost
Copy link

ghost commented Oct 19, 2020

Hi @RebeccaAnne. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Oct 19, 2020
@ghost
Copy link

ghost commented Oct 19, 2020

Hi @RebeccaAnne; Thanks for taking action on your previously stale pull request. Resetting staleness.

@shalinijoshi19
Copy link
Member

@dclaux could you get this a 2nd review pls. Thanks

@RebeccaAnne RebeccaAnne merged commit 9372f16 into main Oct 27, 2020
@RebeccaAnne RebeccaAnne deleted the rebecch/textrundocupdate branch October 27, 2020 16:11
RebeccaAnne pushed a commit that referenced this pull request Oct 27, 2020
…out text shorthand (#4910)

Co-authored-by: shalinijoshi19 <shalinij@microsoft.com>
@v-kydela
Copy link

v-kydela commented Nov 2, 2020

@RebeccaAnne - Can you merge this followup PR? #4973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

String only Inlines are round-tripped as full TextRuns
5 participants