[Android] Fix rendering of inputs with no labels #4995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almedina-ms
changed the title
golddove
approved these changes
Oct 29, 2020
almedina-ms
added a commit
that referenced
this pull request
Oct 29, 2020
* Fix rendering of inputs with no labels * Fix error messages for missing labels too Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
almedina-ms
added a commit
that referenced
this pull request
Oct 29, 2020
* [Android] Switch pipelines to use Windows hosted pools (#4987) * Use Microsoft's Windows hosted agent pools * .bat extension for Windows * Explicit pool name * Remove sudo, because Windows * Windows-style path, because Windows * Trying with cmd script * Fix path * syntax * Disable get ndk * daily too * [Samples][Accessibility] TextBlock wrap in Scenario cards (#4991) * Text: wrap for scenario samples * Copyright, license * More wrap * Missed some * Spaces for indentation Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com> * [Android] Fix rendering of inputs with no labels (#4995) * Fix rendering of inputs with no labels * Fix error messages for missing labels too Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Fix rendering of inputs with no labels * Fix error messages for missing labels too Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4994
Description
Adds a null check validation to stop assuming all inputs have a label for setting accessibility properties, during creation and validation
How Verified
The fix was verified using the linked card giving this result, also, other input types were tested
Microsoft Reviewers: Open in CodeFlow