[NodeJS] Adds getActionById implementation to ActionSet #5002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @scottlovegrove. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
scottlovegrove
changed the title
ghost
added
the
|
Hi @scottlovegrove. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
@matthidinger is there someone I can poke for this PR so it doesn't get closed as inactive? |
|
Hi @scottlovegrove; Thanks for commenting on this previously stale pull request. Resetting staleness. @scottlovegrove FYI. |
dclaux
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #5001
Description
Adds an implementation of
getActionById()to ActionSetWhen calling
ActionSet.getActionById()it is always returningundefinedbecause it is using the base implementation and not a correct one.How Verified
Have added a test for this.
Microsoft Reviewers: Open in CodeFlow