iOS input updates #5030
Merged
iOS input updates #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRColumnSetRenderer.mm
Show resolved
Hide resolved
|
What was the "xib related update for choiceset that we needed to revert?" |
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRChoiceSetViewDataSource.mm
Show resolved
Hide resolved
jwoo-msft
commented
Nov 4, 2020
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRChoiceSetViewDataSource.mm
Show resolved
Hide resolved
shalinijoshi19
approved these changes
Nov 4, 2020
jwoo-msft
added a commit
that referenced
this pull request
Nov 4, 2020
* Reverts ChoiceSet Xib changes * Updated accessibility focus * TextField Input Label View update * code clean-up before CR Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Reverts ChoiceSet Xib changes * Updated accessibility focus * TextField Input Label View update * code clean-up before CR Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixed #5023, Fixed #5024
Description
Input.ChoiceSet had a regression in its layout; reverted ChoiceSet Xib related update
Setting focus on Input.Text and Input.Number caused erratic scrolling behavior. Updated to have the focus to be set on InputView of input, and allowed the scrolling to be handled by the host app, and explicitly set the accessibility focus on the input handler to announce the accessibility l
Sample Card
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.3/Elements/Input.ChoiceSet.ErrorMessage.json
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.3/Elements/Input.Number.Label.json
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.3/Elements/Input.Text.Label.json
How Verified
How you verified the fix, including one or all of the following:
Microsoft Reviewers: Open in CodeFlow