Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[.NET] Automatic tooltip on select action #5045

Merged
merged 5 commits into from
Nov 23, 2020
Merged

Conversation

RebeccaAnne
Copy link
Contributor

@RebeccaAnne RebeccaAnne commented Nov 4, 2020

Related Issue

Fixes #4701

Description

Set the action title as a tooltip on select actions.

Sample Card

Column.SelectAction.json

How Verified

Confirmed tooltip appeared for select actions in the Column.SelectAction card.

Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the no-recent-activity label Nov 14, 2020
@ghost ghost assigned shalinijoshi19 Nov 14, 2020
@ghost
Copy link

ghost commented Nov 14, 2020

Hi @RebeccaAnne. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Nov 17, 2020
@ghost
Copy link

ghost commented Nov 17, 2020

Hi @RebeccaAnne; Thanks for taking action on your previously stale pull request. Resetting staleness.

@ghost ghost added the no-recent-activity label Nov 22, 2020
@ghost ghost assigned matthidinger Nov 22, 2020
@ghost
Copy link

ghost commented Nov 22, 2020

Hi @RebeccaAnne. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Nov 23, 2020
@ghost
Copy link

ghost commented Nov 23, 2020

Hi @RebeccaAnne; Thanks for taking action on your previously stale pull request. Resetting staleness.

Copy link
Member

@shalinijoshi19 shalinijoshi19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shalinijoshi19
Copy link
Member

Is this change also needed on the XCeed renderer?

@RebeccaAnne
Copy link
Contributor Author

Xceed provides us with better controls for inputs via extensibility, it's not it's own whole renderer really. This action rendering code will be the same regardless of whether or not we're using the xceed inputs, so no extra work required there.


In reply to: 732319130 [](ancestors = 732319130)

@RebeccaAnne RebeccaAnne merged commit b32f2da into main Nov 23, 2020
@RebeccaAnne RebeccaAnne deleted the rebecch/dotnettooltip branch November 23, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[.NET] Automatic tooltip for selectAction title
3 participants