Remove extra view from minHeight columnsets #5056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golddove
approved these changes
Nov 6, 2020
ghost
added
the
|
Hi @almedina-ms. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Hi @almedina-ms; Thanks for taking action on your previously stale pull request. Resetting staleness. |
golddove
deleted the
user/almedina-ms/Android_RemoveExtraViewColumnSet
branch
1 task
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #5052
Description
Changes the implementation to avoid adding an extra view to support minHeight property in columnsets
Sample Card
v1.2/Elements/Column.MinHeight.jsonHow Verified
The fix was verified manually with a questionable result that may require is to do an extra step; as can be seen in the image, the values for the fact sets are not visible even when they are rendered, more work is required for this solution
Microsoft Reviewers: Open in CodeFlow