[Pic2card]New approach for layout structuring #5059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keerthana786
changed the title
ghost
added
the
|
Hi @Keerthana786. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
* new layout structuring changes * code cleanup * normalized the grouping thresholds * folder re-strcuturing * code clean-up * Added unittests for layout and object grouping (#37) * fixed pylint errors and code optimisation * pylint fix * removed data property from layout generation * lint errors fixed * code re-structuring * lint fix * added review changes * lint fix * removed duplicate coorinates from the layout-structure * added review-changes * removed unused import * Added alignment property changes * added merging properties and layout ds as a part of card layout generation * get alignment based on number of text lines Co-authored-by: amit <amit.ramachandran@imaginea.com>
|
Hi @Keerthana786; Thanks for taking action on your previously stale pull request. Resetting staleness. |
haridas
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow