Added accessibility label to Image #5069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hi @jwoo-msft. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
golddove
approved these changes
Nov 16, 2020
source/ios/AdaptiveCards/AdaptiveCards/AdaptiveCards/ACRColumnRenderer.mm
Show resolved
Hide resolved
|
Hi @golddove; Thanks for reviewing this previously stale pull request. Resetting staleness. @jwoo-msft FYI. |
1 similar comment
|
Hi @golddove; Thanks for reviewing this previously stale pull request. Resetting staleness. @jwoo-msft FYI. |
|
🎉 Handy links: |
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Added accessibility label to Image * Fixed Column Grouping issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
ADO https://microsoft.visualstudio.com/OS/_queries/edit/29575787/?triage=true
ADO https://microsoft.visualstudio.com/OS/_queries/edit/29254714/?triage=true
Description
Added alt text to Image
Added grouping to Column
Sample Card
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.2/Scenarios/Agenda.json
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.0/Elements/Image.Style.json
How Verified
How you verified the fix, including one or all of the following:
Microsoft Reviewers: Open in CodeFlow