[Android] Fix column widths #5084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please update the description section to also describe the fix you made to the issue? Thanks! |
ghost
added
the
|
Hi @golddove. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Hi @golddove; Thanks for taking action on your previously stale pull request. Resetting staleness. |
|
@RebeccaAnne updated description to reflect that the fix was to match the flex properties to match the JS renderer. Added the new values to the description. |
dclaux
approved these changes
Nov 25, 2020
|
Switched weight from flex-basis to flex-grow, as discussed with @dclaux. Later, should investigate how all other platforms deal with combinations of weight, stretch, auto. |
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Fix column widths * Match JS flex-basis * flex-basis 0 for stretch * flex-grow instead of shrink Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4988
Description
Auto and fixed width columns were shrinking prematurely. To fix, flex params were set to match the JS renderer params, described below:
fixed: grow -0, shrink -0, basis -<px>auto: grow -0, shrink -1, basis -contentstretch: grow -1, shrink -1, basis -0(JS sets a50pxbasis here)weighted: grow -<weight>, shrink -1, basis -0(JS uses weight in basis here)Note: Google's FlexboxLayout library doesn't scale flex-shrink values by flex-basis before applying (unlike CSS flex-shrink). This difference means
autocolumns always shrink to 0 when combined withweightedcolumns (e.g. the icons along the center vertical line inAgenda.jsondisappears) if we use the same configuration as JS. To avoid this, weighted columns useflex-growinstead of relying on interaction betweenflex-shrinkandflex-basis.Sample Card
v1.2\Scenarios\Agenda.jsonv1.2\Scenarios\FlightDetails.jsonAlso verified with samples from Teams production apps.
How Verified
Manual verification. See screenshots above.
Microsoft Reviewers: Open in CodeFlow