[Android] Fix height: stretch elements in columns #5085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golddove
changed the title
RebeccaAnne
reviewed
Nov 17, 2020
| ContainerStyle parentContainerStyle = renderArgs.getContainerStyle(); | ||
| ContainerStyle styleForThis = ContainerRenderer.GetLocalContainerStyle(columnSet, parentContainerStyle); | ||
|
|
||
| for (int i = 0; i < columnVectorSize; i++) | ||
| { | ||
| Column column = columnVector.get(i); | ||
|
|
||
| if(columnSet.GetMinHeight() > column.GetMinHeight()) { |
There was a problem hiding this comment.
{ [](start = 65, length = 1)
[nit] for style consistency with the rest of this code let's put this brace on the next line
1 task
ghost
added
the
|
Hi @golddove. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
|
Hi @golddove; Thanks for taking action on your previously stale pull request. Resetting staleness. |
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* ColumnRenderer back to LinearLayout * Reuse function * ColumnSet minHeight * Address review comment, refactor, remove extraneous empty view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #4989
Description
Elements that use
LinearLayout.LayoutParamsto set weight for vertical stretch fail when those elements are laid out in a FlexboxLayout. There is actually no reason for ColumnRenderer to use flexbox, it just needs the right flex properties set so the ColumnSetRenderer flexbox can correctly layout the child columns. So, reverting to use LinearLayout for ColumnRenderer.Sample Card
(most samples were modified for these screenshots by shortening the text)
v1.1\Tests\ColumnSet*v1.1\Tests\Column.VerticalAlignmentv1.2\Elements\Column.MinHeightv1.2\Elements\ColumnSet.MinHeightHow Verified
Screenshots above
Microsoft Reviewers: Open in CodeFlow