Jwoo/ios luminosity #5089
Merged
Jwoo/ios luminosity #5089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaAnne
approved these changes
Nov 19, 2020
ghost
added
the
|
🎉 Handy links: |
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
* Updated luminosity * fixed luminosity issue on container styles * Updated contrast values Co-authored-by: RebeccaAnne <rebecch@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
ADO https://microsoft.visualstudio.com/OS/_queries/edit/29363030/?triage=true
ADO https://microsoft.visualstudio.com/OS/_queries/edit/29468147/?triage=true
ADO https://microsoft.visualstudio.com/OS/_queries/edit/29576509/?triage=true
ADO https://microsoft.visualstudio.com/OS/_queries/edit/29253854/?triage=true
Description
Adjusted contrast values to fix the luminosity issues.
Sample Card
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.0/Elements/Stylesheet.json
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.0/Tests/CustomParsingTestUsingProgressBar.json
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.2/Tests/Element.Requires.json
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.0/Elements/Container.Style.json
How Verified
How you verified the fix, including one or all of the following:
Microsoft Reviewers: Open in CodeFlow