[TS] Input.Number bug fixes

[dclaux]

Related Issue

Fixes #5092

Description

When min or max where set to 0 in the AC payload, the code would treat them as undefined and thus not stamp them onto the generated <input> tag. This was due to the use of statements like if (!min) which returns true whether min is undefined or equal to 0.

Sample Card

{
    "type": "AdaptiveCard",
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.3",
    "body": [
        {
            "type": "Input.Number",
            "placeholder": "Placeholder text",
            "min": 0,
            "isRequired": true,
            "errorMessage": "Error",
            "id": "dss"
        }
    ],
    "actions": [
        {
            "type": "Action.Submit",
            "title": "Action.Submit"
        }
    ]
}

How Verified

Verified manually in adaptivecards-designer-app

Microsoft Reviewers: Open in CodeFlow

[ghost]

Hi @dclaux. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

[golddove]

Feature request for typescript: this should compile down to a null/undefined check. Truthy/falsy values only cause pain, with very little gain.

[dclaux]

So true