-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS] Allow basic/incomplete extension of ChoiceSetInput #5094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
dclaux
changed the title
[TS] Make ChoiceSetInput.internalApplyAriaCurrent() private
[TS] Allow basic/incomplete extension of ChoiceSetInput
Nov 18, 2020
golddove
approved these changes
Nov 19, 2020
ghost
added
the
no-recent-activity
label
Nov 24, 2020
ghost
assigned RebeccaAnne
Nov 24, 2020
Hi @dclaux. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
ghost
removed
the
no-recent-activity
label
Nov 24, 2020
Hi @dclaux; Thanks for taking action on your previously stale pull request. Resetting staleness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #5091
NOTE: This PR fixes the issue as reported: a custom input that extends
ChoiceSetInput
and only overrides itsinternalRender
method will no longer cause the host app to break. However, the custom input will still have to override additional methods in order to participate in the input validation mechanism and to meet accessibility requirements.Description
ChoiceSetInput.updateInputControlAriaLabelledBy
will not throw anymore on custom inputs that extend ChoiceSetInput and only overrideinternalRender
.ChoiceSetInput.internalApplyAriaCurrent
should not be marked asprotected
because it shouldn't be overridable. This PR makes itprivate
.How Verified
Verified manually in adaptivecards-designer-app
Microsoft Reviewers: Open in CodeFlow