Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] Allow basic/incomplete extension of ChoiceSetInput #5094

Merged
merged 10 commits into from
Nov 24, 2020
Merged

Conversation

dclaux
Copy link
Member

@dclaux dclaux commented Nov 18, 2020

Related Issue

Fixes #5091

NOTE: This PR fixes the issue as reported: a custom input that extends ChoiceSetInput and only overrides its internalRender method will no longer cause the host app to break. However, the custom input will still have to override additional methods in order to participate in the input validation mechanism and to meet accessibility requirements.

Description

  • ChoiceSetInput.updateInputControlAriaLabelledBy will not throw anymore on custom inputs that extend ChoiceSetInput and only override internalRender.
  • Non-issue related: ChoiceSetInput.internalApplyAriaCurrent should not be marked as protected because it shouldn't be overridable. This PR makes it private.

How Verified

Verified manually in adaptivecards-designer-app

Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Nov 18, 2020

Hi @dclaux. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@dclaux dclaux changed the title [TS] Make ChoiceSetInput.internalApplyAriaCurrent() private [TS] Allow basic/incomplete extension of ChoiceSetInput Nov 18, 2020
@ghost ghost added the no-recent-activity label Nov 24, 2020
@ghost ghost assigned RebeccaAnne Nov 24, 2020
@ghost
Copy link

ghost commented Nov 24, 2020

Hi @dclaux. This non-spec pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Nov 24, 2020
@ghost
Copy link

ghost commented Nov 24, 2020

Hi @dclaux; Thanks for taking action on your previously stale pull request. Resetting staleness.

@dclaux dclaux merged commit 8f42f78 into main Nov 24, 2020
@dclaux dclaux deleted the js/bug-fixes branch November 24, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Javascript][Extensibility] [Rendering breaks on registering custom element for multiple/expanded choiceset]
3 participants