[JS] Audit updates #5119
Merged
[JS] Audit updates #5119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcam206
added
Platform-JavaScript
|
Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
dclaux
approved these changes
Dec 1, 2020
paulcam206
force-pushed
the
paulcam/cg-nodejs-audits
branch
from
42845cb
to
ac10af8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to package dependency versions for security reasons. Also introduce new auditing tool to make handling auditing easier (since
lernastill doesn't have integrated audit support, and breaksnpm auditdue to how it links together monorepo packages).From
sources/nodejsyou can now issuenpm run audit-all, which will do the equivalent of annpm audit fixfor each project.One small tweak -- moving to a newer version of
hexomeant that theexternal_links: truedirective insource/nodejs/adaptivecards-site/_config.ymlis deprecated:The fix was easy enough as seen in the diff.
How Verified
Microsoft Reviewers: Open in CodeFlow