Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Ingest marked-schema package #5128

Merged
merged 27 commits into from
Dec 4, 2020
Merged

Conversation

paulcam206
Copy link
Member

@paulcam206 paulcam206 commented Dec 3, 2020

Description

While addressing some package updates, marked-schema showed up as needing updating. As it's now pretty tightly coupled with our spec-generator package, it makes more sense to just ingest the codebase into our repo.

How Verified

  • local build
Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Dec 3, 2020

Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@@ -0,0 +1,201 @@
Apache License
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthidinger - do we have any concerns with just bringing this package in with its existing license?

@paulcam206 paulcam206 merged commit e70d161 into main Dec 4, 2020
@paulcam206 paulcam206 deleted the paulcam/ingest-marked-schema branch December 4, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants