Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Sample Card for Accessibility Compliance #5153

Merged
merged 2 commits into from
Dec 10, 2020

Conversation

jwoo-msft
Copy link
Member

@jwoo-msft jwoo-msft commented Dec 10, 2020

Related Issue

Fixed ADO issue

Description

Sample card has a wrong place holder text of "enter comment" for Input.Number.

Sample Card

https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.2/Tests/ColumnSet.AllElements.Stretch.ToggleVisibility.json

How Verified

  1. Manual scenario verification if any; Do include .gif's or screenshots of the testing you performed here if you think that it
    will aid in code reviews or corresponding fixes on other platforms for eg.

Before

MAS1 3 1_Incorrect placeholder is present with “Input Number” edit field on “ColumnSet AllElements Stretch Toggle” page

After

image

Microsoft Reviewers: Open in CodeFlow

@jwoo-msft jwoo-msft merged commit 14bf9b0 into main Dec 10, 2020
@jwoo-msft jwoo-msft deleted the jwoo/ios-sample-update-for-accessiblity branch December 10, 2020 04:48
@golddove golddove added this to the 20.11-12 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants