Feature/associated inputs #5155
Conversation
* Action.Submit.associatedInputs support * Remove unnecessary imports. Better README * Remove unnecessary code
* Add property and re-swig * Remove unused ignoreInputValidation, add tests * Fix test, re-swig
* [UWP] Add support for associatedInputs none value * Code review feedback Co-authored-by: Risheek Rajolu <risheekrr@gmail.com>
* [Schema] Add associatedInputs to the schema and docs * Add default to schema
* Implemented associated input * addressed the review comments
* AssociatedInputs.None Android * Unintended change
|
Hi @RebeccaAnne. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes. |
|
@RebeccaAnne @paulcam206 what was the resolution about the XML doc files? Do we want to commit and start tracking them? |
I can delete them if we don't want them. But if we don't want them we should also add them to .gitignore because right now everytime I build .NET they show up and I have to delete them. Or, alternatively, if they're supposed to get deleted by the build process we should figure out why they don't (at least locally for me). |
|
I went ahead and deleted them and logged #5157 to figure out what we want to happen to these. |
|
you can ignore the failing |
* [JS] Action.Submit.associatedInputs support (microsoft#5136) * Action.Submit.associatedInputs support * Remove unnecessary imports. Better README * Remove unnecessary code * [Shared] Add associatedInputs property to Action.Submit (microsoft#5139) * Add property and re-swig * Remove unused ignoreInputValidation, add tests * Fix test, re-swig * [UWP] Add support for associatedInputs none value (microsoft#5141) * [UWP] Add support for associatedInputs none value * Code review feedback Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> * [.NET] Add support for associatedInputs none value (microsoft#5137) * [Schema] Add associatedInputs to the schema and docs (microsoft#5140) * [Schema] Add associatedInputs to the schema and docs * Add default to schema * Implemented associated input (microsoft#5148) * Implemented associated input * addressed the review comments * [Android] Support associatedInputs: none (microsoft#5152) * AssociatedInputs.None Android * Unintended change * Delete xml doc files Co-authored-by: David Claux <dclaux@users.noreply.github.com> Co-authored-by: Risheek Rajolu <risheekrr@gmail.com> Co-authored-by: Joseph Woo <Joseph.Woo@microsoft.com> Co-authored-by: Paul Campbell <paulcam@microsoft.com>
Related Issue
Fixes #5078
Description
Merges feature branch containing all platforms implementations of asssociatedInputs none to main
Sample Card
Sample card added as samples\v1.3\Elements\Action.Submit.AssociatedInputs.json
How Verified
See individual PRs for per platform verification performed
Microsoft Reviewers: Open in CodeFlow