Fixed issues discovered with the smoke test #5185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golddove
approved these changes
Dec 12, 2020
|
We should consider using a common sample host config on all platforms. |
Good idea. @jwoo-msft / @golddove can one of you file this for us to review/revisit/track? Thanks. |
shalinijoshi19
approved these changes
Dec 14, 2020
created #5186 to track the issue. |
jwoo-msft
added a commit
that referenced
this pull request
Dec 14, 2020
Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com>
rankush
pushed a commit
to rankush/AdaptiveCards
that referenced
this pull request
May 8, 2024
Co-authored-by: Shalini Joshi-MSFT <shalinij@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixed #5180
Fixed #5179
Description
#5180, Sample host config picked up the wrong separator value.
#5179, Input validator set the border to zero when input validation passed. This works as inputs don't have explicit borders except for input with multi-lines. this fix stores the original border params when inputs are initialized to use them to restore to original values after validation succeeds after a failure.
Sample Card
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.0/Elements/AdaptiveCard.json
https://github.com/microsoft/AdaptiveCards/blob/main/samples/v1.0/Elements/ColumnSet.Spacing.json
How Verified
How you verified the fix, including one or all of the following:
Microsoft Reviewers: Open in CodeFlow