[NET] Fix up PackageReferences to reflect our requirements #5230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An issue came up in an email thread regarding package dependency versioning for .NET. The issue was expressed specifically about the HTML renderer, though the problem actually affects other renderers as well -- our
Newtonsoft.Jsonrequirements are inconsistent (11.0.2for most pieces of our stack, and12.0.3for the templating library). The fix is to be more explicit about version ranges we allow. However, the templating library depends onAdaptiveExpressions, which itself depends on12.0.3, so the only way for this all to work is to relax theNU1605warning (package downgrade detected) forNewtonsoft.Json. Since I was already in here, I also moved us from fixed specific versions to wildcarded patch versions (aside from a range forNewtonsoft.Json).It's probably worth noting that the original request was to move the full stack over to using
Newtonsoft.Json >= 12.*, but we can't do that due to some clients requiring11.x(see #3413).How Verified
Microsoft Reviewers: Open in CodeFlow